i/linux
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

direct-io: Prevent NULL pointer access in submit_page_section

Browse Source 
commit 899f0429c7d3eed886406cd72182bee3b96aa1f9 upstream.

In the code added to function submit_page_section by commit b1058b981,
sdio->bio can currently be NULL when calling dio_bio_submit.  This then
leads to a NULL pointer access in dio_bio_submit, so check for a NULL
bio in submit_page_section before trying to submit it instead.

Fixes xfstest generic/250 on gfs2.

Signed-off-by: Andreas Gruenbacher <agruenba@redhat.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Andreas Gruenbacher
2017-10-09 11:13:18 +02:00
committed by Greg Kroah-Hartman
parent 3941ee2083
commit f9139a1a24
1 changed files with 2 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
fs/direct-io.c
+2 -1
View File
@@ -835,7 +835,8 @@ out:
*/ */
if (sdio->boundary) { if (sdio->boundary) {
ret = dio_send_cur_page(dio, sdio, map_bh); ret = dio_send_cur_page(dio, sdio, map_bh);
dio_bio_submit(dio, sdio); if (sdio->bio)
dio_bio_submit(dio, sdio);
put_page(sdio->cur_page); put_page(sdio->cur_page);
sdio->cur_page = NULL; sdio->cur_page = NULL;
} }